-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduced new component Carousel.Caption #1734
introduced new component Carousel.Caption #1734
Conversation
Carousel.Caption replaces the following bootstrap code: ```<div className="carousel-caption">``` cf. Media.Body from react-bootstrap#1707 for a similar change.
If you are including Carousel as follows before this change:
You will receive the following error when e.g. using webpack:
To fix this, change the require to this:
|
export default Carousel; | ||
|
||
export { Caption }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this amounts to a breaking change, so i'd either need to go in the 0.29 branch or (preferablly) just remove the named export since the Static property on Carousel is fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The downside is a breaking change, the upside is consistency with e.g. Media.
That being said, I defer to you. Let me know which you'd like me to do, PR to 0.29 branch or modify the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a mistake on <Media>
. We'll fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
LGTM |
1 similar comment
LGTM |
I wonder if we should have |
Carousel.Caption replaces the following bootstrap code:
<div className="carousel-caption">
cf. Media.Body from #1707 for a similar change.