Register and unregister clients with proxy to fix data race, and tidy the surrounding code #55
Conversation
|
Pull request must be merged with a description containing the required fields, Summary: If there is no jira releated to this change, please put 'Jira: NO-JIRA'. Description can be changed by editing the top comment on your pull request and making a new commit. |
|
Coverage statistics of your commit: |
|
Coverage statistics of your commit: |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/a92b29375a37216de0235a175dc7a2f9 |
|
build-brcm-refboard3 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/6b685e1ac79e259463cfb476afdd5b9a |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
'['RPI4 IPSTB']' Sanity test FAILURE, investigation pending. |
|
'['RPI4 IPSTB']' Sanity test FAILURE, investigation pending. |
|
Sanity tests for ['BCM 7216OTT Refboard VA'] added. |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
'['RPI4 IPSTB']' Sanity test FAILURE, investigation pending. |
|
Sanity tests for ['RPI4 IPSTB'] added. |
|
rialto interface change has been undone, therefore this pull request is no longer necessary |
Summary: register and unregister clients (of control) via a proxy (this prevents a data race and updates c style pointers to c++). The call to registerClient in ControlService::addControl was deceiving since this didn't actually register any client... it just called setApplicationState therefore changed to call setApplicationState() direct (and then "controlServerInternal" doesn't need a "registerClient" method). Also the control method registerClient() is renamed to registerClientAndUnregisterOnDestruction() which is a more complete description of what it does
Type: Fix
Test Plan: UT/CT and test webaudio on XiOne US box
Jira: NO-JIRA