Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse FCL_LDFLAGS #708

Closed
wants to merge 3 commits into from
Closed

Parse FCL_LDFLAGS #708

wants to merge 3 commits into from

Conversation

cielavenir
Copy link
Collaborator

Since we already have used the technique in bulletrave, why don't we use it also in fclrave? And I updated bulletrave comment as well.

As current origin/master and origin/production are the same, it is up to you which to merge.

Note: if this is merged, please close #640

@rdiankov
Copy link
Owner

does "${PLUGIN_LINK_FLAGS}" ${FCL_LDFLAGS}work?

@cielavenir
Copy link
Collaborator Author

@rdiankov I confirmed that would cause #633 if /usr/local/lib/pkgconfig/fcl.pc's Libs is only -lfcl. Usual fcl.pc.in has Libs -L${libdir} -lfcl, so we were not aware the corner case.

@cielavenir
Copy link
Collaborator Author

#795 appeared...

@cielavenir
Copy link
Collaborator Author

closing this one

@cielavenir cielavenir closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants