Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AsUTF8AndSize #1491

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Use AsUTF8AndSize #1491

merged 2 commits into from
Feb 26, 2025

Conversation

cielavenir
Copy link
Collaborator

PyUnicode_GET_LENGTH (#1488) was wrong, @Puttichai pointed out

@Puttichai Puttichai requested a review from rdiankov February 26, 2025 08:11
@cielavenir cielavenir requested a review from Puttichai February 26, 2025 14:46
@cielavenir
Copy link
Collaborator Author

pipeline https://tiny.mujin.co.jp/s9kc0

@rdiankov rdiankov merged commit c09d0d1 into production Feb 26, 2025
1 check passed
@rdiankov
Copy link
Owner

thanks

@rdiankov rdiankov deleted the useAsUTF8AndSize branch February 26, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdiankov rdiankov Awaiting requested review from rdiankov

@Puttichai Puttichai Awaiting requested review from Puttichai

Assignees

@rdiankov rdiankov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cielavenir @rdiankov