Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async select syscall #164

Merged
merged 6 commits into from
Aug 28, 2020
Merged

Add async select syscall #164

merged 6 commits into from
Aug 28, 2020

Conversation

yunwei37
Copy link
Contributor

@yunwei37 yunwei37 commented Aug 26, 2020

  • Add async select syscall
  • add time out support in async for poll and select
  • add test for poll and select
  • add doc

@coveralls
Copy link

coveralls commented Aug 26, 2020

Pull Request Test Coverage Report for Build 226239204

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 128 of 140 (91.43%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.7%) to 49.039%

Changes Missing Coverage Covered Lines Changed/Added Lines %
linux-syscall/src/file/poll.rs 107 119 89.92%
Files with Coverage Reduction New Missed Lines %
linux-syscall/src/file/poll.rs 2 85.56%
linux-syscall/src/lib.rs 2 48.78%
Totals Coverage Status
Change from base Build 220845524: 1.7%
Covered Lines: 7401
Relevant Lines: 15092

💛 - Coveralls

@yunwei37 yunwei37 marked this pull request as ready for review August 27, 2020 01:03
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In the future, we may use the select! macro to simplify the implementation of select, poll and timeout.

@wangrunji0408 wangrunji0408 merged commit f4406b3 into rcore-os:master Aug 28, 2020
@wangrunji0408 wangrunji0408 added the enhancement New feature or request label Aug 30, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants