Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve doc and add some simple trivial test in linux-loader #128

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

yunwei37
Copy link
Contributor

@yunwei37 yunwei37 commented Aug 6, 2020

  • linux-loader passes #![deny(missing_docs)]
  • add some simple test using busybox command to improve the coverage in linux-loader:
    • fs
      • copy and remove
      • link and unlink
      • create and remove dir
      • readfile
    • date
    • mkdir

It seems most command in the busybox need more syscalls.

@coveralls
Copy link

coveralls commented Aug 6, 2020

Pull Request Test Coverage Report for Build 197867979

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 22 of 24 (91.67%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.9%) to 32.641%

Changes Missing Coverage Covered Lines Changed/Added Lines %
linux-loader/src/lib.rs 0 1 0.0%
linux-loader/src/main.rs 22 23 95.65%
Files with Coverage Reduction New Missed Lines %
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/async-std-1.6.2/src/sync/mutex.rs 4 77.78%
Totals Coverage Status
Change from base Build 197305326: 2.9%
Covered Lines: 4085
Relevant Lines: 12515

💛 - Coveralls

@wangrunji0408 wangrunji0408 self-requested a review August 7, 2020 01:51
@wangrunji0408 wangrunji0408 merged commit d737834 into rcore-os:master Aug 7, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
Improve doc and add some simple trivial test in `linux-loader`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants