Cap tox at 2.4.0 to avoid env substitution bug #1496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tox 2.4.0 was released this morning and broke the ability to use environment substitution. To avoid this and keep our continuous integration happy while we complete our work, we prevent travis from installing any version of tox 2.4.0 or later. Related-to tox-dev/tox#380 Connects rcbops/u-suk-dev#512 (cherry picked from commit 3e18ce8)
|
👎 there's a new version of tox that fixes this appropriately. I'd like to see what happens with #1497 before we merge this so that we do not have to cap tox long term. |
|
👎 @sigmavirus24 #1497 Passed tests. I'll do a backport. |
|
#1499 out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tox 2.4.0 was released this morning and broke the ability to use
environment substitution. To avoid this and keep our continuous
integration happy while we complete our work, we prevent travis from
installing any version of tox 2.4.0 or later.
Related-to tox-dev/tox#380
Connects rcbops/u-suk-dev#512
(cherry picked from commit 3e18ce8)