Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role triggers .user.ini integrity check with nextcloud 13.0.4 #10

Closed
lalmeras opened this issue Jun 16, 2018 · 3 comments
Closed

Role triggers .user.ini integrity check with nextcloud 13.0.4 #10

lalmeras opened this issue Jun 16, 2018 · 3 comments

Comments

@lalmeras
Copy link
Contributor

In nextcloud 13.0.4, max_input_time and max_execution_time configuration are dropped from .user.ini. As Nextcloud checks .user.ini consistency by copying installed file, setting default values on copied file, then computing file checksum (described here: nextcloud/server#115).

As the .user.ini deployed by the role contains this configuration items, integrity check now fails, with a warning in administration pages (see screen capture). This does not prevent nextcloud to work.

The better way I see to fix it is to template .user.ini to drop problematic section, based on ansible_version variable.

Do you see / plan any other fix ? Interested by a PR for this ?

nextcloud-integrity

@rbicker
Copy link
Owner

rbicker commented Jun 18, 2018

Hi, thanks for your message. I am already working on a fix using lineinfile with backrefs=yes instead of a template. This way, the line will only be modified if it already exists. I need to do some more testing but I will probably push the change by the end of this week. BR

rbicker pushed a commit that referenced this issue Jun 19, 2018
@rbicker
Copy link
Owner

rbicker commented Jun 19, 2018

I just pushed my fix. During my tests, I saw that max_execution_time and max_input_time were also missing in older versions of nextcloud. Not sure why the consistency check used to succeed.

I ended up putting these options in /etc/php.ini

@rbicker rbicker closed this as completed Jun 19, 2018
@lalmeras
Copy link
Contributor Author

I think this bug was revealed by my last PR, as code integrity check is performed by update/setup scripts. As my PR fixed the fact that during upgrade, nextcloud original .user.ini was not modified with custom settings, no integrity violation were detected.

Thanks for your quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants