Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching 20230221 #390

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Caching 20230221 #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f045d1
prevent cache modification when parallel fetches are waiting on the s…
carrolp Feb 21, 2023
c62bf1a
package updates
carrolp Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/FetchEnvs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ module.exports = class FetchEnvs {
// When updating a key, updating it for all users
for( const cacheUser of globalResourceCacheUsers ) {
if( globalResourceCache.has(`${cacheUser}/${cacheKey}`) ) {
globalResourceCache.set(`${cacheUser}/${cacheKey}`, resource);
globalResourceCache.set(`${cacheUser}/${cacheKey}`, clone(resource));
updated = true;
}
}
Expand Down Expand Up @@ -162,7 +162,7 @@ module.exports = class FetchEnvs {
}

// Wait for the outstanding api call to complete, use it's value
resource = await singleResourceQueryCache[cacheKey];
resource = clone( await singleResourceQueryCache[cacheKey] );
}

return resource;
Expand Down
Loading