add basedownloadcontroller unit tests #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 11, 2023 15:38
adamkingit
reviewed
Jan 11, 2023
lib/MockDownloadController.js
Outdated
|
|
||
| module.exports = class MockDownloadController extends BaseDownloadController { | ||
| constructor(eventData, kubeData) { | ||
| let params = {}; |
There was a problem hiding this comment.
Suggested change
| let params = {}; | |
| const params = {}; |
adamkingit
reviewed
Jan 11, 2023
lib/MockKubeResourceMeta.js
Outdated
| const res = await this.kubeGetResource(ref); | ||
| return res; | ||
| try { | ||
| let uri = JSON.parse(reqOpt.uri); |
There was a problem hiding this comment.
Suggested change
| let uri = JSON.parse(reqOpt.uri); | |
| const uri = JSON.parse(reqOpt.uri); |
adamkingit
reviewed
Jan 11, 2023
| const clone = require('clone'); | ||
| const objectPath = require('object-path'); | ||
|
|
||
| let kubeData = {}; |
There was a problem hiding this comment.
Suggested change
| let kubeData = {}; | |
| const kubeData = {}; |
There was a problem hiding this comment.
gets reset in afterEach, so can't change to const
adamkingit
reviewed
Jan 11, 2023
test/basedownloadcontroller-tests.js
Outdated
Comment on lines
286
to
289
| let eventDataUpdate = clone(kubeData['RemoteResource'][0]); | ||
| eventDataUpdate = { | ||
| object: eventDataUpdate | ||
| }; |
There was a problem hiding this comment.
Suggested change
| let eventDataUpdate = clone(kubeData['RemoteResource'][0]); | |
| eventDataUpdate = { | |
| object: eventDataUpdate | |
| }; | |
| const eventDataUpdate = { | |
| object: clone(kubeData['RemoteResource'][0]) | |
| }; |
adamkingit
reviewed
Jan 11, 2023
test/basedownloadcontroller-tests.js
Outdated
Comment on lines
320
to
323
| let eventDataUpdate = clone(kubeData['RemoteResource'][0]); | ||
| eventDataUpdate = { | ||
| object: eventDataUpdate | ||
| }; |
There was a problem hiding this comment.
Suggested change
| let eventDataUpdate = clone(kubeData['RemoteResource'][0]); | |
| eventDataUpdate = { | |
| object: eventDataUpdate | |
| }; | |
| const eventDataUpdate = { | |
| object: clone(kubeData['RemoteResource'][0]) | |
| }; |
adamkingit
reviewed
Jan 11, 2023
adamkingit
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.