Update: add selfLink annotation before returning getResource #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all resources returned via kubeclass getResource will include the selfLink annotation
all resources returned via the watchman event objectHandler will include the selfLink annotation
adamkingit
reviewed
Aug 25, 2020
| @@ -119,6 +119,15 @@ module.exports = class KubeClass { | |||
| } | |||
|
|
|||
|
|
|||
| injectSelfLink(object, resourceMeta) { | |||
| let resources = objectPath.get(object, 'items', []); | |||
There was a problem hiding this comment.
Is it possible to get an individual resource here instead if a list?
There was a problem hiding this comment.
the way its making the request let response = await request.get(resourceMeta.uri(), options); tells me it is always doing a listing, never getting a specific resource. eg. resourceMeta.uri() doesnt specify a name or namespace in the options, so it will always be a list of resources
adamkingit
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.