Add examples to par_split_mut and par_chunks_mut #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add an odd tail to the `par_chunks` example.
KodrAus
reviewed
Feb 12, 2018
| /// let windows: Vec<_> = [1, 2, 3, 4].par_chunks(2).collect(); | ||
| /// assert_eq!(vec![[1, 2], [3, 4]], windows); | ||
| /// let chunks: Vec<_> = [1, 2, 3, 4, 5].par_chunks(2).collect(); | ||
| /// assert_eq!(chunks, vec![&[1, 2][..], &[3, 4], &[5]]); |
There was a problem hiding this comment.
We don't need the trailing [..] here, right?
There was a problem hiding this comment.
It needs to be forced as a slice instead of array, or else the type of [5] won't match.
I think I could do this like let expected: Vec<&[_]> = ... if that's clearer.
There was a problem hiding this comment.
Ah yep. I personally think the way it is now is fine to read, I was just nit-picking for the sake of the review.
nikomatsakis
approved these changes
Feb 14, 2018
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 14, 2018
528: Replace coco with crossbeam-deque r=nikomatsakis a=cuviper These are the changes from @stjepang and @jeehoonkang, replacing and closing #480. The minimum rustc is *slightly* increased from 1.12 to 1.13 for the transitive requirements. 530: Add examples to par_split_mut and par_chunks_mut r=nikomatsakis a=cuviper Also add an odd tail to the `par_chunks` example. cc #420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add an odd tail to the
par_chunksexample.cc #420