420 document parallel iterator methods #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/iter/mod.rs
Outdated
| /// | ||
| /// let (sender, receiver) = channel(); | ||
| /// | ||
| /// let mut par_iter = (0..5).into_par_iter().map_with(sender, |s, x| { s.send(x).unwrap(); x }); |
There was a problem hiding this comment.
Nit: can we format this a bit more clearly? Maybe run the example through rustfmt (on play) and paste it back? I feel like it's a bit hard to follow what's happening. (Also, some comments explaining what's going on wouldn't hurt.)
| /// use rayon::prelude::*; | ||
| /// let sums = [(0, 1), (5, 6), (16, 2), (8, 9)] | ||
| /// .par_iter() // iterating over &(i32, i32) | ||
| /// .cloned() // iterating over (i32, i32) |
There was a problem hiding this comment.
formatting like this is great =)
nikomatsakis
requested changes
Jan 23, 2018
|
@nikomatsakis Thanks for your review. |
nikomatsakis
approved these changes
Feb 6, 2018
|
bors r+ |
Build failed |
|
bors r=nikomatsakis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution for closing #420.
There is one method left in the
ParallelIteratortrait that has no example:opt_len.Also the example for
fold_withmight not be necessary.