Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy_static 1.1.0 requires newer rustc #587

Closed
cuviper opened this issue Aug 6, 2018 · 0 comments
Closed

lazy_static 1.1.0 requires newer rustc #587

cuviper opened this issue Aug 6, 2018 · 0 comments

Comments

@cuviper
Copy link
Member

cuviper commented Aug 6, 2018

rayon-core depends on lazy_static = "1". This has been working fine with our Rust 1.13 baseline, but in lazy_static 1.1.0 they're now using associated constants, which were stabilized in Rust 1.20. Their CI script is currently testing Rust 1.21 as their baseline.

  • We could leave Rayon alone, and manually downgrade lazy_static for our older CI.
  • We could pin our requirement to lazy_static = "~1.0".
    • That's generally unfriendly to other crates in your graph that want lazy_static.
  • We could bump our requirement to Rust 1.21 too.
    • Rust 1.21 was release on 2017-10-12, almost 10 months ago.
    • This would also let us move to newer crossbeam-deque. 0.3 requires Rust 1.20; 0.4 and 0.5 require Rust 1.25.

attn: @nikomatsakis -- I already know you feel less conservative about minimum rustc though...

bors bot added a commit that referenced this issue Aug 8, 2018
Merge #589

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
589: Force lazy_static 1.0.2 for older CI r=cuviper a=cuviper

Fixes #587.

Co-authored-by: Josh Stone <cuviper@gmail.com>
bors bot added a commit that referenced this issue Aug 8, 2018
Merge #589

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
589: Force lazy_static 1.0.2 for older CI r=cuviper a=cuviper

Fixes #587.

Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors bors bot closed this as completed in #589 Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant