Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added an id attribute to the input #2

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

gregmsanderson
Copy link
Contributor

πŸ”— Linked issue

#1

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The input's label has the for attribute, specifying an element ID. However the input element does not have that ID. As such, clicking the label does not move focus to the form element. Adding the ID should resolve that.

This should resolve #1

You will need to check it is correct: you appear to use this same approach for other elements and so it should work.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

The input's label has the for attribute, specifying an element ID. However the input element does not have that ID. As such, clicking the label does not move focus to the form element. Adding the ID should resolve that.
@raymondmuller
Copy link
Owner

Thanks @gregmsanderson, appreciate that!

@raymondmuller raymondmuller merged commit 65563cd into raymondmuller:main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The input element appears to be missing the id attribute
2 participants