-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mailtrap extension #17157
base: main
Are you sure you want to change the base?
Update mailtrap extension #17157
Conversation
- fix: empty result causing crash on .map undefined - Initial commit
Thank you for your first contribution! 🎉 🔔 @samjwillis97 @xmok you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR updates the Mailtrap extension to improve error handling and URL formatting.
- Fixed potential crashes by handling undefined results from Mailtrap API in
extensions/mailtrap/src/services/mailtrap.ts
- Removed extraneous curly braces from Mailtrap API URLs for better formatting
- Added new contributor "chrisclose-nib" to package.json
- Added appropriate changelog entry with {PR_MERGE_DATE} placeholder
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@greptileai can you check this again please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
This PR enhances the Mailtrap extension's pagination system by implementing cursor-based pagination using the last_id parameter, ensuring no emails are missed between page loads.
- Changed pagination logic in
extensions/mailtrap/src/services/mailtrap.ts
to use cursor-based approach with MAILTRAP_PAGE_SIZE constant (30) - Improved reliability by preventing missed emails during pagination with last_id parameter
The changes are focused and specific, improving the extension's reliability without introducing unnecessary complexity.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Description
}
on the mailtrap urls, which mailtrap forgaveScreencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder