Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mailtrap extension #17157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update mailtrap extension #17157

wants to merge 2 commits into from

Conversation

CL0SeY
Copy link

@CL0SeY CL0SeY commented Feb 19, 2025

Description

  • fix: empty result causing crash on .map undefined
  • improvement: change pagination to work based on the last loaded email, so that emails do not get missed in-between pages
  • fix: remove extra } on the mailtrap urls, which mailtrap forgave

Screencast

Checklist

- fix: empty result causing crash on .map undefined
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: mailtrap Issues related to the mailtrap extension labels Feb 19, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Feb 19, 2025

Thank you for your first contribution! 🎉

🔔 @samjwillis97 @xmok you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

Copy link
Contributor

@samjwillis97 samjwillis97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the Mailtrap extension to improve error handling and URL formatting.

  • Fixed potential crashes by handling undefined results from Mailtrap API in extensions/mailtrap/src/services/mailtrap.ts
  • Removed extraneous curly braces from Mailtrap API URLs for better formatting
  • Added new contributor "chrisclose-nib" to package.json
  • Added appropriate changelog entry with {PR_MERGE_DATE} placeholder

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

@CL0SeY CL0SeY requested a review from samjwillis97 February 20, 2025 06:03
Copy link
Contributor

@samjwillis97 samjwillis97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@CL0SeY
Copy link
Author

CL0SeY commented Feb 20, 2025

@greptileai can you check this again please

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR enhances the Mailtrap extension's pagination system by implementing cursor-based pagination using the last_id parameter, ensuring no emails are missed between page loads.

  • Changed pagination logic in extensions/mailtrap/src/services/mailtrap.ts to use cursor-based approach with MAILTRAP_PAGE_SIZE constant (30)
  • Improved reliability by preventing missed emails during pagination with last_id parameter

The changes are focused and specific, improving the extension's reliability without introducing unnecessary complexity.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: mailtrap Issues related to the mailtrap extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants