Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brreg extension #16927

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add brreg extension #16927

wants to merge 5 commits into from

Conversation

holene
Copy link

@holene holene commented Feb 9, 2025

Description

Search and retrieve information about Norwegian companies (Enhetsregisteret) directly from the Raycast command bar. The extension uses the official Brønnøysund Register Center (Brreg) API to find companies by name or organisation number.

Screencast

Checklist

- changes access
- fixed prettier error
- updated author
- initial commit
- initial commit
- added productivity and web
- new, shorter description
- added signature
- removed some comments
- updated to comply with extension requirements
- added icons and updated metadata
- fixed some ts whine
- english lang. plus cmd+shift+enter hotkey for opening in brreg.no
- Functional search and go-to-page func for bbreg
- Initial commit
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Feb 9, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Feb 9, 2025

Congratulations on your new Raycast extension! 🚀

Due to our current reduced availability, the initial review may take up to 10-15 business days

Once the PR is approved and merged, the extension will be available on our Store.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds a new Raycast extension for searching Norwegian companies through the Brønnøysund Register Center API, enabling users to look up company information directly from the command bar.

  • Implementation in /extensions/brreg/src/brreg-search.tsx provides search by name or organization number with proper error handling and loading states
  • Package configuration in package.json includes all required dependencies and proper Raycast extension metadata
  • Well-documented README with clear features, requirements and privacy considerations
  • Character encoding issues present in README text where special characters like 'ø' are not properly displayed
  • Command description in package.json could be more descriptive than just "Input org. name"

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

8 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile

const data = (await response.json()) as EnheterResponse;
setEnheter(data._embedded?.enheter || []);
} catch (error) {
showToast(Toast.Style.Failure, "Failed to fetch enheter", (error as { message?: string })?.message);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Error message 'Failed to fetch enheter' should be translated to English for consistency

actions={
<ActionPanel>
<Action.CopyToClipboard content={enhet.organisasjonsnummer} title="Copy Org.nr." />
{addressString && <Action.CopyToClipboard content={addressString} title="Copy Forretningsadresse" />}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Title 'Forretningsadresse' should be translated to English for consistency

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update all variables to match in a later PR

holene and others added 2 commits February 18, 2025 08:20
PR Bot suggestion

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
PR Bot suggestion

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

No major changes found since last review. The core functionality and implementation remain the same as previously reviewed, with no significant modifications to the codebase that would warrant additional comments.

Note: If you make any substantial changes to the code, feel free to request another review by mentioning @greptileai in a comment.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants