Let driver own pcollections #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
iasoon
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Very nice @jjyao!
As the reason for this packing/unpacking of the arguments is a bit non-obvious in my opinion, I'm wondering what the best way would be to make these kinds of design decisions discoverable to readers of the code. Any thoughts? (Certainly not blocking to merge this)
Signed-off-by: Pablo <pabloem@users.noreply.github.com>
Signed-off-by: Pablo <pabloem@users.noreply.github.com>
Signed-off-by: Pablo <pabloem@users.noreply.github.com>
|
I'll merge after tests pass |
|
thanks everyone : ) |
|
@iasoon, sorry for the late reply. I'll apply ray-project/ray#28291 to this PR so we no longer need to calculate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiajun Yao jeromeyjj@gmail.com
With this PR, driver will own all the data of pcollections and handle the object lose automatically.
Closes #34