[Data] Persist unresolved paths in FileBasedDataSource. #51424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
richardliaw
approved these changes
Mar 17, 2025
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
…51424) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This PR adds support for storing the original, unresolved paths in the `FileBasedDatasource` class. This allows components to access the raw path pattern provided by the user before any path resolution or expansion occurs. This also adds consistency with [`ParquetDatasource`](https://github.com/ray-project/ray/blob/936539ce15bffa8dfa0a519fee2c7c8c0ee341b8/python/ray/data/_internal/datasource/parquet_datasource.py#L202) and [`_FileDatasink`](https://github.com/ray-project/ray/blob/936539ce15bffa8dfa0a519fee2c7c8c0ee341b8/python/ray/data/datasource/file_datasink.py#L66). ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [x] This PR is not tested :( Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Drice1999
pushed a commit
to Drice1999/ray
that referenced
this pull request
Mar 23, 2025
…51424) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This PR adds support for storing the original, unresolved paths in the `FileBasedDatasource` class. This allows components to access the raw path pattern provided by the user before any path resolution or expansion occurs. This also adds consistency with [`ParquetDatasource`](https://github.com/ray-project/ray/blob/936539ce15bffa8dfa0a519fee2c7c8c0ee341b8/python/ray/data/_internal/datasource/parquet_datasource.py#L202) and [`_FileDatasink`](https://github.com/ray-project/ray/blob/936539ce15bffa8dfa0a519fee2c7c8c0ee341b8/python/ray/data/datasource/file_datasink.py#L66). ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [x] This PR is not tested :( Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
dhakshin32
pushed a commit
to dhakshin32/ray
that referenced
this pull request
Mar 27, 2025
…51424) <!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> ## Why are these changes needed? This PR adds support for storing the original, unresolved paths in the `FileBasedDatasource` class. This allows components to access the raw path pattern provided by the user before any path resolution or expansion occurs. This also adds consistency with [`ParquetDatasource`](https://github.com/ray-project/ray/blob/936539ce15bffa8dfa0a519fee2c7c8c0ee341b8/python/ray/data/_internal/datasource/parquet_datasource.py#L202) and [`_FileDatasink`](https://github.com/ray-project/ray/blob/936539ce15bffa8dfa0a519fee2c7c8c0ee341b8/python/ray/data/datasource/file_datasink.py#L66). ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [x] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [x] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [x] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [x] This PR is not tested :( Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> Signed-off-by: Dhakshin Suriakannu <d_suriakannu@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds support for storing the original, unresolved paths in the
FileBasedDatasourceclass. This allows components to access the raw path pattern provided by the user before any path resolution or expansion occurs.This also adds consistency with
ParquetDatasourceand_FileDatasink.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.