Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove from grpc.experimental import aio as aiogrpc #50363

Merged
merged 3 commits into from
Feb 11, 2025

Conversation

kevin85421
Copy link
Member

@kevin85421 kevin85421 commented Feb 9, 2025

Why are these changes needed?

Starting with grpc v1.32.0, the aio module was moved out of the experimental directory into the main directories. The latest grpc release is v1.70.1, and v1.32.0 was released 4.5 years ago.

I searched the Ray codebase for references to grpcio. Most of them specify grpcio v1.66.1. The oldest reference to a grpcio version is v1.32.0, which has already been moved to the main directories.

"grpcio >= 1.32.0; python_version < '3.10'", # noqa:E501

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kevin85421 kevin85421 added the go add ONLY when ready to merge, run all tests label Feb 9, 2025
@kevin85421
Copy link
Member Author

The CI failure is unrelated.
image

@kevin85421 kevin85421 marked this pull request as ready for review February 9, 2025 20:01
@pcmoritz pcmoritz enabled auto-merge (squash) February 11, 2025 21:05
@pcmoritz pcmoritz merged commit dbd9a54 into ray-project:master Feb 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants