Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] De-glob all cc targets #50334

Merged
merged 1 commit into from
Feb 9, 2025
Merged

[core] De-glob all cc targets #50334

merged 1 commit into from
Feb 9, 2025

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Feb 8, 2025 •
edited
Loading

Followup PR for #50243, which deglobs ALL cc targets.

I will followup with other PRs to split targets:

  • Place CC targets under certain directory
  • Split one giant targets into smaller ones

@dentiny dentiny added the go add ONLY when ready to merge, run all tests label Feb 8, 2025
@dentiny dentiny requested review from jjyao, dayshah and aslonnie February 8, 2025 02:07
@dentiny
deglob all cc targets
1fa75fc 
Signed-off-by: dentiny <dentinyhao@gmail.com>
@dentiny dentiny force-pushed the hjiang/deglob-all-cc-targets branch from 30800cb to 1fa75fc Compare February 8, 2025 02:09
@jjyao jjyao merged commit 9e3ec59 into ray-project:master Feb 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslonnie aslonnie aslonnie approved these changes

@jjyao jjyao Awaiting requested review from jjyao

@dayshah dayshah Awaiting requested review from dayshah

Assignees

@jjyao jjyao

@dayshah dayshah

@aslonnie aslonnie

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dentiny @aslonnie @jjyao @dayshah