-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Update TPU Documentation #50056
Conversation
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
doc/source/cluster/kubernetes/user-guides/gcp-gke-tpu-cluster.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/user-guides/gcp-gke-tpu-cluster.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/user-guides/gcp-gke-tpu-cluster.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
Signed-off-by: Ryan O'Leary <ryanaoleary@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor comments, LGTM otherwise
doc/source/cluster/kubernetes/user-guides/gcp-gke-tpu-cluster.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/user-guides/gcp-gke-tpu-cluster.md
Outdated
Show resolved
Hide resolved
I have already pinged Ray doc team to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from docs perspective
is someone with write access able to merge this for me? @dayshah @kevin85421 |
Why are these changes needed?
This PR contains some small edits to the TPU Ray documentation to clarify the sections, specifically making it more clear that the Ray TPU initialization webhook is included in the GKE Ray addon and manual installation is optional.
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.