Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] MetricsLogger cleanup throughput logic. #49981

Merged
merged 7 commits into from
Jan 22, 2025
Merged

[RLlib] MetricsLogger cleanup throughput logic. #49981

merged 7 commits into from
Jan 22, 2025
+16 −33

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 21, 2025 •
edited
Loading

MetricsLogger cleanup throughput logic.

  • For simplicity, MetricsLogger/Stats should automatically compute the throughput for all keys that have reduce=sum and clear_on_reduce=False ("lifetime counts").
  • There is no performance hit to do so.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
9feb9ce 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
2938e82 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 added rllib RLlib related issues rllib-logging This problem is related to logging metrics rllib-newstack labels Jan 21, 2025
simonsays1980
simonsays1980 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small question.

rllib/utils/metrics/stats.py Outdated
self._throughput = 0.0
self._measure_throughput = False
if (
self._reduce_method == "sum"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dumb question: Why is this only relevant for sum? Because these are the only lifetime stats?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only reduce setting, for which it makes sense to measure throughput for. Doesn't really make sense for min/max/mean.

@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into metr…
7c74aa7 
…ics_logger_cleanup_throughput
@sven1977
wip
6ba009f 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into metr…
2069acc 
…ics_logger_cleanup_throughput
@sven1977
wip
0079456 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) January 22, 2025 09:28
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jan 22, 2025
@sven1977 sven1977 merged commit 68527f2 into ray-project:master Jan 22, 2025
6 of 7 checks passed
@sven1977 sven1977 deleted the metrics_logger_cleanup_throughput branch January 22, 2025 12:29
win5923 pushed a commit to win5923/ray that referenced this pull request Jan 23, 2025
@sven1977 @win5923
[RLlib] MetricsLogger cleanup throughput logic. (ray-project#49981)
4541731
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Jan 23, 2025
@sven1977 @simonsays1980
[RLlib] MetricsLogger cleanup throughput logic. (ray-project#49981)
c2ed851
anson627 pushed a commit to anson627/ray that referenced this pull request Jan 31, 2025
@sven1977 @anson627
[RLlib] MetricsLogger cleanup throughput logic. (ray-project#49981)
a3d76b9 
Signed-off-by: Anson Qian <anson627@gmail.com>
anson627 pushed a commit to anson627/ray that referenced this pull request Jan 31, 2025
@sven1977 @anson627
[RLlib] MetricsLogger cleanup throughput logic. (ray-project#49981)
a139a34 
Signed-off-by: Anson Qian <anson627@gmail.com>
srinathk10 pushed a commit that referenced this pull request Feb 2, 2025
@sven1977 @srinathk10
[RLlib] MetricsLogger cleanup throughput logic. (#49981)
ffcb43a
anyadontfly pushed a commit to anyadontfly/ray that referenced this pull request Feb 13, 2025
@sven1977 @anyadontfly
[RLlib] MetricsLogger cleanup throughput logic. (ray-project#49981)
4339384 
Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-logging This problem is related to logging metrics rllib-newstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980