Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Update BayesOptSearch docs #49848

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

till-m
Copy link
Contributor

@till-m till-m commented Jan 15, 2025

Why are these changes needed?

The current documentation of the BayesOptSearch is incomplete/wrong.

  • It doesn't specify the version of the package which should be installed (1.4.3 as far as I can tell: link)
  • There is a link to an example notebook, but it is not version pinned, instead pointing to master.
  • References to the repo are still going to @fmfn's personal repository and not the the organization repository.

I've updated the docstrings. The PR is untested, as I assume the docstring change should not affect tests passing.
NB: I am a member of bayesian-optimization.

Related issue number

see also #49845

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: till-m <musertill@gmail.com>
@jcotant1 jcotant1 added the train Ray Train Related Issue label Jan 15, 2025
@hongpeng-guo hongpeng-guo added tune Tune-related issues and removed train Ray Train Related Issue labels Jan 21, 2025
Copy link
Contributor

@hongpeng-guo hongpeng-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for fixing the doc string. It looks good to me. cc @matthewdeng @justinvyu for merging.

@hongpeng-guo hongpeng-guo changed the title Update BayesOptSearch docs [Tune] Update BayesOptSearch docs Jan 21, 2025
@justinvyu justinvyu enabled auto-merge (squash) January 22, 2025 00:15
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jan 22, 2025
@justinvyu justinvyu merged commit c2d9600 into ray-project:master Jan 22, 2025
6 checks passed
win5923 pushed a commit to win5923/ray that referenced this pull request Jan 23, 2025
The current documentation of the `BayesOptSearch` is incomplete/wrong.
- It doesn't specify the version of the package which should be
installed (`1.4.3` as far as I can tell: link)
- There is a link to an example notebook, but it is not version pinned,
instead pointing to `master`.
- References to the repo are still going to @fmfn's personal repository
and not the the organization repository.

Signed-off-by: till-m <musertill@gmail.com>
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Jan 23, 2025
The current documentation of the `BayesOptSearch` is incomplete/wrong.
- It doesn't specify the version of the package which should be
installed (`1.4.3` as far as I can tell: link)
- There is a link to an example notebook, but it is not version pinned,
instead pointing to `master`.
- References to the repo are still going to @fmfn's personal repository
and not the the organization repository.

Signed-off-by: till-m <musertill@gmail.com>
anson627 pushed a commit to anson627/ray that referenced this pull request Jan 31, 2025
The current documentation of the `BayesOptSearch` is incomplete/wrong.
- It doesn't specify the version of the package which should be
installed (`1.4.3` as far as I can tell: link)
- There is a link to an example notebook, but it is not version pinned,
instead pointing to `master`.
- References to the repo are still going to @fmfn's personal repository
and not the the organization repository.

Signed-off-by: till-m <musertill@gmail.com>
Signed-off-by: Anson Qian <anson627@gmail.com>
anson627 pushed a commit to anson627/ray that referenced this pull request Jan 31, 2025
The current documentation of the `BayesOptSearch` is incomplete/wrong.
- It doesn't specify the version of the package which should be
installed (`1.4.3` as far as I can tell: link)
- There is a link to an example notebook, but it is not version pinned,
instead pointing to `master`.
- References to the repo are still going to @fmfn's personal repository
and not the the organization repository.

Signed-off-by: till-m <musertill@gmail.com>
Signed-off-by: Anson Qian <anson627@gmail.com>
srinathk10 pushed a commit that referenced this pull request Feb 2, 2025
The current documentation of the `BayesOptSearch` is incomplete/wrong.
- It doesn't specify the version of the package which should be
installed (`1.4.3` as far as I can tell: link)
- There is a link to an example notebook, but it is not version pinned,
instead pointing to `master`.
- References to the repo are still going to @fmfn's personal repository
and not the the organization repository.

Signed-off-by: till-m <musertill@gmail.com>
anyadontfly pushed a commit to anyadontfly/ray that referenced this pull request Feb 13, 2025
The current documentation of the `BayesOptSearch` is incomplete/wrong.
- It doesn't specify the version of the package which should be
installed (`1.4.3` as far as I can tell: link)
- There is a link to an example notebook, but it is not version pinned,
instead pointing to `master`.
- References to the repo are still going to @fmfn's personal repository
and not the the organization repository.

Signed-off-by: till-m <musertill@gmail.com>
Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests tune Tune-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants