Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Add time between sample metric to MultiAgentEnvRunner. #49687

Merged
merged 3 commits into from
Jan 7, 2025
Merged

[RLlib] Add time between sample metric to MultiAgentEnvRunner. #49687

merged 3 commits into from
Jan 7, 2025

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Jan 7, 2025

Add time between sample metric to MultiAgentEnvRunner.

  • Analogous to already existing metric in SingleAgentEnvRunner.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
31e484c 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
simonsays1980
simonsays1980 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice change. We need to think about the metrics we want to record for Offline RL and also the metrics from buffers.

rllib/env/multi_agent_env_runner.py
@@ -128,6 +130,8 @@ def __init__(self, config: AlgorithmConfig, **kwargs):

self._weights_seq_no: int = 0

self._time_after_sampling = None
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave a comment about what this attribute is for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sven1977 sven1977 enabled auto-merge (squash) January 7, 2025 17:52
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jan 7, 2025
@sven1977
wip
5bc5a01 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@github-actions github-actions bot disabled auto-merge January 7, 2025 18:03
@sven1977 sven1977 enabled auto-merge (squash) January 7, 2025 18:19
@sven1977 sven1977 merged commit 1420cbc into ray-project:master Jan 7, 2025
6 checks passed
@sven1977 sven1977 deleted the add_time_between_sample_metric_to_ma_env_runner branch January 8, 2025 08:28
roshankathawate pushed a commit to roshankathawate/ray that referenced this pull request Jan 9, 2025
@sven1977 @roshankathawate
[RLlib] Add time between sample metric to MultiAgentEnvRunner. (r…
3361894 
…ay-project#49687)

Signed-off-by: Roshan Kathawate <roshankathawate@gmail.com>
HYLcool pushed a commit to HYLcool/ray that referenced this pull request Jan 13, 2025
@sven1977 @HYLcool
[RLlib] Add time between sample metric to MultiAgentEnvRunner. (r…
6f7e1e5 
…ay-project#49687)

Signed-off-by: lielin.hyl <lielin.hyl@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980