[RLlib] Cleanup examples folder vol. 41: Add new example on async gym vector env. #49527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nup_examples_folder_41_async_vector_env
simonsays1980
approved these changes
Jan 3, 2025
| if self.config.remote_worker_envs | ||
| else VectorizeMode.SYNC | ||
| vectorize_mode | ||
| if isinstance(vectorize_mode, gym.envs.registration.VectorizeMode) |
There was a problem hiding this comment.
Isn't this already validated in AlgorithmConfig? Imo we need to validate only once. Either here or in the AlgorithmConfig.
There was a problem hiding this comment.
True, but an AlgorithmConfig only gets validated in the algo, not when it enters an EnvRunner. So - in theory - users could still run into this if they instantiate an EnvRunner in isolation with some config that has this defined as a string (e.g. "SYNC").
| ---------------------- | ||
| `python [script file name].py --enable-new-api-stack ` | ||
|
|
||
| Use the `--vectorize-mode=BOTH` option to run both modes (SYNC and ASYNC) |
|
|
||
| tune.register_env("slow-env", _env_creator) | ||
|
|
||
| if args.vectorize_mode == "BOTH" and args.no_tune: |
There was a problem hiding this comment.
Why not just setting no_tune=False if vectorize_mode="BOTH"?
There was a problem hiding this comment.
Good catch. Added an error, instead and simplified the if-statement.
| @@ -1087,9 +1087,11 @@ def run_rllib_example_script_experiment( | |||
| enable_env_runner_and_connector_v2=False, | |||
| ) | |||
|
|
|||
| # Define EnvRunner/RolloutWorker scaling and behavior. | |||
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 7, 2025
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 9, 2025
… vector env. (ray-project#49527) Signed-off-by: Roshan Kathawate <roshankathawate@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup examples folder vol. 41: Add new example on async gym vector env.
vale).Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.