[RLlib] Add on_episode_created callback to SingleAgentEnvRunner.
#49487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsays1980
approved these changes
Dec 30, 2024
| @@ -393,6 +393,11 @@ def _sample( | |||
| observation_space=self.env.single_observation_space, | |||
| action_space=self.env.single_action_space, | |||
| ) | |||
| self._make_on_episode_callback( | |||
There was a problem hiding this comment.
Nice, so this works again.
There was a problem hiding this comment.
Yeah, b/c the new gym 1.x does NOT automatically reset a done vector subenv anymore, but requires you to take the extra step from terminal observation to reset observation "manually". This allows us to slip in the callback again.
…on_episode_created_to_single_agent_env_runner
srinathk10
pushed a commit
that referenced
this pull request
Jan 3, 2025
anyadontfly
pushed a commit
to anyadontfly/ray
that referenced
this pull request
Feb 13, 2025
…ay-project#49487) Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
on_episode_createdcallback toSingleAgentEnvRunner.With gymnasium=1.x in place, making this callback is now supported (b/c of the extra step required to get from terminal state to reset state).
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.