-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard] Move StateHead's methods into free functions. #49388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
jjyao
approved these changes
Jan 2, 2025
srinathk10
pushed a commit
that referenced
this pull request
Jan 3, 2025
StateHead and its StateAPIManager has a pretty big footprint. It serves all `api/v0/*` APIs, and hence reads from all data sources: GcsClient, Raylets, Agents. It keeps a bunch of methods for transformation of data. To break it down and split out dependencies, we first refactor by moving these transformation methods into free functions, so that other Heads can make use of them. This PR is no-op in runtime, but serves as a foundation for moving some APIs to other heads. --------- Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 7, 2025
…t#49388) StateHead and its StateAPIManager has a pretty big footprint. It serves all `api/v0/*` APIs, and hence reads from all data sources: GcsClient, Raylets, Agents. It keeps a bunch of methods for transformation of data. To break it down and split out dependencies, we first refactor by moving these transformation methods into free functions, so that other Heads can make use of them. This PR is no-op in runtime, but serves as a foundation for moving some APIs to other heads. --------- Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
roshankathawate
pushed a commit
to roshankathawate/ray
that referenced
this pull request
Jan 9, 2025
…t#49388) StateHead and its StateAPIManager has a pretty big footprint. It serves all `api/v0/*` APIs, and hence reads from all data sources: GcsClient, Raylets, Agents. It keeps a bunch of methods for transformation of data. To break it down and split out dependencies, we first refactor by moving these transformation methods into free functions, so that other Heads can make use of them. This PR is no-op in runtime, but serves as a foundation for moving some APIs to other heads. --------- Signed-off-by: Ruiyang Wang <rywang014@gmail.com> Signed-off-by: Roshan Kathawate <roshankathawate@gmail.com>
anyadontfly
pushed a commit
to anyadontfly/ray
that referenced
this pull request
Feb 13, 2025
…t#49388) StateHead and its StateAPIManager has a pretty big footprint. It serves all `api/v0/*` APIs, and hence reads from all data sources: GcsClient, Raylets, Agents. It keeps a bunch of methods for transformation of data. To break it down and split out dependencies, we first refactor by moving these transformation methods into free functions, so that other Heads can make use of them. This PR is no-op in runtime, but serves as a foundation for moving some APIs to other heads. --------- Signed-off-by: Ruiyang Wang <rywang014@gmail.com> Signed-off-by: Puyuan Yao <williamyao034@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StateHead and its StateAPIManager has a pretty big footprint. It serves all
api/v0/*
APIs, and hence reads from all data sources: GcsClient, Raylets, Agents. It keeps a bunch of methods for transformation of data.To break it down and split out dependencies, we first refactor by moving these transformation methods into free functions, so that other Heads can make use of them.
This PR is no-op in runtime, but serves as a foundation for moving some APIs to other heads.