[RLlib] Fix schedule validation on new API stack (for config settings like lr
or entropy_coeff
).
#49363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix schedule validation on new API stack (for config settings like
lr
orentropy_coeff
)._schedule
settings for the corresponding main settings, such aslr
orentropy_coeff
.config.training(lr=[[0, 0.0001], [1e6, 0.0000001]])
.lr_schedule
orentropy_coeff_schedule
are not (and have never been) supported on the new API stack.config.training(lr=None, lr_schedule=[[]...])
and instead use the defaultAdam
lr (0.001) under the hood.This PR fixes the validation and throws an error.
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.