Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix schedule validation on new API stack (for config settings like lr or entropy_coeff). #49363

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 19, 2024

Fix schedule validation on new API stack (for config settings like lr or entropy_coeff).

  • The new API stack has no special _schedule settings for the corresponding main settings, such as lr or entropy_coeff.
  • Instead, schedules for these settings must be passed into the "main" setting, e.g. config.training(lr=[[0, 0.0001], [1e6, 0.0000001]]).
  • The old stack's lr_schedule or entropy_coeff_schedule are not (and have never been) supported on the new API stack.
  • Thus far, on the new API stack, however, the config validation would fail to recognize an erroneous config.training(lr=None, lr_schedule=[[]...]) and instead use the default Adam lr (0.001) under the hood.

This PR fixes the validation and throws an error.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 added rllib RLlib related issues rllib-algorithms An RLlib algorithm/Trainer is not learning. rllib-newstack and removed rllib-algorithms An RLlib algorithm/Trainer is not learning. labels Dec 19, 2024
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 enabled auto-merge (squash) December 19, 2024 12:27
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Dec 19, 2024
@github-actions github-actions bot disabled auto-merge December 19, 2024 12:50
@sven1977 sven1977 enabled auto-merge (squash) December 19, 2024 12:50
@sven1977 sven1977 merged commit cff17ee into ray-project:master Dec 19, 2024
6 checks passed
@sven1977 sven1977 deleted the fix_validation_of_lr_and_lr_schedule_new_api_stack branch December 19, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests rllib RLlib related issues rllib-newstack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants