[core] Minor update on task manager #49272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hjiang <hjiang@anyscale.com>
dentiny
commented
Dec 14, 2024
| } | ||
| } | ||
| } | ||
| if (!resubmit) { |
There was a problem hiding this comment.
Main change here, follows best practice to early return.
dentiny
commented
Dec 14, 2024
| @@ -304,6 +304,8 @@ std::vector<rpc::ObjectReference> TaskManager::AddPendingTask( | |||
| } | |||
|
|
|||
| bool TaskManager::ResubmitTask(const TaskID &task_id, std::vector<ObjectID> *task_deps) { | |||
| RAY_CHECK(task_deps->empty()); | |||
There was a problem hiding this comment.
Add an assertion before emplace.
dentiny
commented
Dec 14, 2024
| @@ -268,8 +268,9 @@ class TaskManager : public TaskFinisherInterface, public TaskResubmissionInterfa | |||
| /// responsible for making sure that these dependencies become available, so | |||
| /// that the resubmitted task can run. This is only populated if the task was | |||
| /// not already pending and was successfully resubmitted. | |||
| /// \return OK if the task was successfully resubmitted or was | |||
| /// already pending, Invalid if the task spec is no longer present. | |||
| /// \return true if the task was successfully resubmitted (task or actor being | |||
There was a problem hiding this comment.
@jjyao I actually have a question on how we retry and retrieve retry result, task manager only submit task, but not blocking wait their completion; task recovery manager also doesn't block wait. Is there any concern?
There was a problem hiding this comment.
Discussed offline. It doesn't block, it's async operation.
jjyao
approved these changes
Dec 18, 2024
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Dec 18, 2024
Signed-off-by: hjiang <hjiang@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, perform some minor C++ optimization / cleanup for task manager.