Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serve] Add missing DEPLOY_FAILED state transitions #49225

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[serve] Add missing DEPLOY_FAILED state transitions #49225

merged 1 commit into from
Dec 12, 2024

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Dec 12, 2024

Why are these changes needed?

Allow deployment to transition out of DEPLOY_FAILED into UPDATING.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@zcin
deploy failed state transitions
eaab116 
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
@zcin zcin requested a review from GeneDer December 12, 2024 02:12
GeneDer
GeneDer approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but feel we should just add tests to cover all possible state transitions XP (and again can be in a follow up)

@zcin zcin added the go add ONLY when ready to merge, run all tests label Dec 12, 2024
@zcin zcin merged commit bdbbf74 into ray-project:master Dec 12, 2024
5 checks passed
@zcin zcin deleted the deploy-failed-patch branch December 12, 2024 03:45
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Dec 12, 2024
@zcin @simonsays1980
[serve] Add missing DEPLOY_FAILED state transitions (ray-project#49225)
47a2b80 
## Why are these changes needed?

Allow deployment to transition out of `DEPLOY_FAILED` into `UPDATING`.


Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
@zcin @ujjawal-khare
[serve] Add missing DEPLOY_FAILED state transitions (ray-project#49225)
a5a07ba 
## Why are these changes needed?

Allow deployment to transition out of `DEPLOY_FAILED` into `UPDATING`.

Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeneDer GeneDer GeneDer approved these changes

Assignees
No one assigned
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcin @GeneDer