[Data] support passing kwargs to map tasks. #49208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65e6cd9 to
3710d83
Compare
0687f16 to
022d7f5
Compare
bveeramani
approved these changes
Dec 11, 2024
|
LGTM! |
simonsays1980
pushed a commit
to simonsays1980/ray
that referenced
this pull request
Dec 12, 2024
## Why are these changes needed? This PR enables passing kwargs to map tasks, which will be accessible via `TaskContext.kwargs`. This is a prerequisite to fixing ray-project#49207. And optimization rules can use this API to pass additional arguments to the map tasks. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com>
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Dec 17, 2024
## Why are these changes needed? This PR enables passing kwargs to map tasks, which will be accessible via `TaskContext.kwargs`. This is a prerequisite to fixing ray-project#49207. And optimization rules can use this API to pass additional arguments to the map tasks. --------- Signed-off-by: Hao Chen <chenh1024@gmail.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR enables passing kwargs to map tasks, which will be accessible via
TaskContext.kwargs.This is a prerequisite to fixing #49207. And optimization rules can use this API to pass additional arguments to the map tasks.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.