Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Display duration in milliseconds if under 1 second. #49126

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[Dashboard] Display duration in milliseconds if under 1 second. #49126

merged 3 commits into from
Dec 11, 2024

Conversation

coltwood93
Copy link
Contributor

Why are these changes needed?

On the Ray Dashboard, a duration less than 1 second is displayed as "0s", which is not accurate.

Related issue number

Closes #49010

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@coltwood93
added milliseconds to duration under 1 minute
4cc2f3b 
Signed-off-by: Colton Woodruff <coltwood93@gmail.com>
@coltwood93
added testing for milliseconds duration
ebbcd33 
Signed-off-by: Colton Woodruff <coltwood93@gmail.com>
alanwguo
alanwguo approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@alanwguo alanwguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! looks great

@alanwguo alanwguo added the go add ONLY when ready to merge, run all tests label Dec 6, 2024
@jcotant1 jcotant1 added dashboard Issues specific to the Ray Dashboard observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling labels Dec 9, 2024
@jjyao jjyao merged commit 4e55864 into ray-project:master Dec 11, 2024
4 of 5 checks passed
simonsays1980 pushed a commit to simonsays1980/ray that referenced this pull request Dec 12, 2024
@coltwood93 @simonsays1980
[Dashboard] Display duration in milliseconds if under 1 second. (ray-…
bcb667c 
…project#49126)

Signed-off-by: Colton Woodruff <coltwood93@gmail.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Dec 17, 2024
@coltwood93 @ujjawal-khare
[Dashboard] Display duration in milliseconds if under 1 second. (ray-…
051f17a 
…project#49126)

Signed-off-by: Colton Woodruff <coltwood93@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwguo alanwguo alanwguo approved these changes

Assignees
No one assigned
Labels
dashboard Issues specific to the Ray Dashboard go add ONLY when ready to merge, run all tests observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dashboard] For durations less than 1s, show ms instead
4 participants
@coltwood93 @alanwguo @jjyao @jcotant1