[RLlib] APPO enhancements (new API stack) vol 02: Cleanup loss function, add GAE-lambda to vtrace, make rho-clip configurable. #48800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonsays1980
approved these changes
Nov 19, 2024
|
|
||
| # Target policy. | ||
| target_action_dist = action_dist_cls_train.from_logits( | ||
| module.forward_target(batch)[TARGET_ACTION_DIST_LOGITS_KEY] |
There was a problem hiding this comment.
Can we do this here, if we want ot use multiple learners? I remember for SAC and CQL we needed to run a single forward pass before the loss calculation.
There was a problem hiding this comment.
You are right, but it does seem to run fine in the CI (multi-GPU). 🤷♂️
| # The discount factor that is used should be gamma except for timesteps where | ||
| # the episode is terminated. In that case, the discount factor should be 0. | ||
| # The discount factor that is used should be `gamma * lambda_`, except for | ||
| # termination timesteps, in which case the discount factor should be 0. |
There was a problem hiding this comment.
Why not gamma^(t-1)?
dentiny
pushed a commit
to dentiny/ray
that referenced
this pull request
Dec 7, 2024
…on, add GAE-lambda to vtrace, make rho-clip configurable. (ray-project#48800) Signed-off-by: hjiang <dentinyhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APPO enhancements (new API stack) vol 02:
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.