[Core] Stop the GRPC server before Shut down the Object Store #48572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e conditions Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
rynewang
approved these changes
Nov 7, 2024
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…oject#48572) In a recent investigation, we saw `Broken pipe` issue when a node is being preempted and going through the shutdown process. This is issue is due to a race condition: * The node is being preempted and is being gracefully shut down. * At the same time, remote hosts receives the notifications that the node state changes and send `FreeObjects` requests to the node * When handling the `FreeObjects` request, the Raylet will call `Delete` on the local Object store. * However, when the `Delete` happens, the object store has already been stopped and thus caused the Broken Pipe issue. The fix in the code is to move the logic to shutdown GRPC server before stopping the object store. In this sense, we can make sure when stopping the Object Store, there will not be on-going or future GRPC requests. Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…oject#48572) In a recent investigation, we saw `Broken pipe` issue when a node is being preempted and going through the shutdown process. This is issue is due to a race condition: * The node is being preempted and is being gracefully shut down. * At the same time, remote hosts receives the notifications that the node state changes and send `FreeObjects` requests to the node * When handling the `FreeObjects` request, the Raylet will call `Delete` on the local Object store. * However, when the `Delete` happens, the object store has already been stopped and thus caused the Broken Pipe issue. The fix in the code is to move the logic to shutdown GRPC server before stopping the object store. In this sense, we can make sure when stopping the Object Store, there will not be on-going or future GRPC requests. Signed-off-by: Mengjin Yan <mengjinyan3@gmail.com> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In a recent investigation, we saw
Broken pipeissue when a node is being preempted and going through the shutdown process.This is issue is due to a race condition:
FreeObjectsrequests to the nodeFreeObjectsrequest, the Raylet will callDeleteon the local Object store.Deletehappens, the object store has already been stopped and thus caused the Broken Pipe issue.The fix in the code is to move the logic to shutdown GRPC server before stopping the object store. In this sense, we can make sure when stopping the Object Store, there will not be on-going or future GRPC requests.
Related issue number
Close #48568
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.