[Data] Mark num_rows_per_file as experimental
#48208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
raulchen
approved these changes
Oct 23, 2024
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
If you don't have the access to it, we will shortly find a reviewer and num_rows_per_file has known issues. In specific: - If the number of rows per block is larger than the specified value, then Ray Data writes the number of rows per block to each file. - If specified value isn't divisible by the number of rows per block, then Ray Data writes fewer than the specified value (i.e., the remainder) to some files. - Writes aren't streamed (in the sense that all blocks for that write are stored in heap memory at the same time), so this feature is prone to OOMing Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
If you don't have the access to it, we will shortly find a reviewer and num_rows_per_file has known issues. In specific: - If the number of rows per block is larger than the specified value, then Ray Data writes the number of rows per block to each file. - If specified value isn't divisible by the number of rows per block, then Ray Data writes fewer than the specified value (i.e., the remainder) to some files. - Writes aren't streamed (in the sense that all blocks for that write are stored in heap memory at the same time), so this feature is prone to OOMing Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
If you don't have the access to it, we will shortly find a reviewer and num_rows_per_file has known issues. In specific: - If the number of rows per block is larger than the specified value, then Ray Data writes the number of rows per block to each file. - If specified value isn't divisible by the number of rows per block, then Ray Data writes fewer than the specified value (i.e., the remainder) to some files. - Writes aren't streamed (in the sense that all blocks for that write are stored in heap memory at the same time), so this feature is prone to OOMing Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
num_rows_per_filehas known issues. In specific:Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.