[data/preprocessors] do not fail transform_batch on missing column #48137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardliaw
reviewed
Oct 21, 2024
| @@ -113,6 +125,8 @@ def test_simple_imputer(): | |||
|
|
|||
| assert constant_out_df.equals(constant_expected_df) | |||
|
|
|||
| # | |||
richardliaw
approved these changes
Oct 21, 2024
| @@ -131,7 +131,14 @@ def _transform_pandas(self, df: pd.DataFrame): | |||
| if is_categorical_dtype(df.dtypes[column]): | |||
| df[column] = df[column].cat.add_categories(value) | |||
|
|
|||
| df = df.fillna(new_values) | |||
| for column_name in new_values: | |||
There was a problem hiding this comment.
can you add this behavior to the docstring as well?
cb46a3d to
29a1ffc
Compare
omatthew98
approved these changes
Oct 23, 2024
| @@ -13,7 +13,8 @@ | |||
|
|
|||
| @PublicAPI(stability="alpha") | |||
| class SimpleImputer(Preprocessor): | |||
| """Replace missing values with imputed values. | |||
| """Replace missing values with imputed values. If the column is missing from a | |||
| batch, it will be filled with the imputed valuegit. | |||
Signed-off-by: Martin Bomio <martinbomio@gmail.com>
29a1ffc to
ef5d192
Compare
|
@omatthew98 @richardliaw would you mind merging, I can't |
richardliaw
approved these changes
Oct 23, 2024
Jay-ju
pushed a commit
to Jay-ju/ray
that referenced
this pull request
Nov 5, 2024
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…ay-project#48137) Signed-off-by: JP-sDEV <jon.pablo80@gmail.com>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…ay-project#48137) Signed-off-by: mohitjain2504 <mohit.jain@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Closes #48047
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.