-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADAG] Add visualization of compiled graphs #47958
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6bf6489
add
Bye-legumes 09ab8a7
add
Bye-legumes 5586c11
fix
Bye-legumes 756dbc4
fix
Bye-legumes e23d156
fix
Bye-legumes c94f2bf
fix
Bye-legumes f5b6f88
fix
Bye-legumes 0eadadf
fix
Bye-legumes 486986f
fix
Bye-legumes 3db6aac
fix
Bye-legumes aa06b8f
fix
Bye-legumes ac02067
Merge branch 'master' into adag_visulization
Bye-legumes 5a8043a
fix
Bye-legumes 2afa26f
Merge branch 'master' into adag_visulization
Bye-legumes bbd2066
fix
Bye-legumes 298cf3a
Merge branch 'master' into adag_visulization
Bye-legumes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are test failures for this file. Please fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that graphviz is not available on the test environment so we need to
pip install graphviz
andsudo apt-get install graphviz
for visualization test. Do you know how we can achieve that in the test environments? I need to add dependency to which file for pip and apt-get? @ruisearch42There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can introduce something like a test requirement.txt , something like python/requirements/ml/data-test-requirements.txt
If that is too complex, we can skip the test for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just skip these tests and I think it's OK now.