Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Train] Remove deprecated mosaic and sklearn trainer code #47901

Merged
merged 5 commits into from
Oct 8, 2024
Merged

[Train] Remove deprecated mosaic and sklearn trainer code #47901

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1af97fa
Add more nuanced checks for http proxy status code error
Superskyyy Oct 4, 2024
cb93f7a
Remove dead code from deprecated mosaic and sklearn trainers
Superskyyy Oct 4, 2024
3cf79ab
Remove mosaic reference
Superskyyy Oct 4, 2024
dcb56af
Revert accidental change
Superskyyy Oct 4, 2024
4e864cc
Further cleanup MosaicTrainer from codebase
Superskyyy Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions python/ray/air/_internal/usage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,9 @@
AIR_TRAINERS = {
"HorovodTrainer",
"LightGBMTrainer",
"MosaicTrainer",
"SklearnTrainer",
"TensorflowTrainer",
"TorchTrainer",
"XGBoostTrainer",
"HuggingFaceTrainer", # Deprecated: Remove in 2.7.
}

# searchers implemented by Ray Tune.
Expand Down
8 changes: 0 additions & 8 deletions python/ray/train/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,14 +487,6 @@ py_test(
deps = [":train_lib", ":conftest"]
)

py_test(
name = "test_sklearn_predictor",
size = "small",
srcs = ["tests/test_sklearn_predictor.py"],
tags = ["team:ml", "exclusive", "ray_air"],
deps = [":train_lib", ":conftest"]
)

py_test(
name = "test_storage",
size = "small",
Expand Down
4 changes: 2 additions & 2 deletions python/ray/train/mosaic/__init__.py
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can go ahead and remove this entirely, the RayLogger was only used as part of the MosaicTrainer before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks!

Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
from ray.train.mosaic.mosaic_trainer import MosaicTrainer
from ray.train.mosaic._mosaic_utils import RayLogger

__all__ = ["MosaicTrainer"]
__all__ = ["RayLogger"]
30 changes: 0 additions & 30 deletions python/ray/train/mosaic/mosaic_trainer.py
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also do a quick scan to remove anything that might reference these? e.g. I saw there is a python/ray/train/examples/mosaic_cifar10_example.py that references the MosaicTrainer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will do that

This file was deleted.

9 changes: 0 additions & 9 deletions python/ray/train/sklearn/__init__.py
View file
Open in desktop

This file was deleted.

64 changes: 0 additions & 64 deletions python/ray/train/sklearn/sklearn_checkpoint.py
View file
Open in desktop

This file was deleted.

172 changes: 0 additions & 172 deletions python/ray/train/sklearn/sklearn_predictor.py
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions python/ray/train/sklearn/sklearn_trainer.py
View file
Open in desktop

This file was deleted.

Loading