Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix runtime env race condition when uploading the same package concurrently #47482

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[Core] Fix runtime env race condition when uploading the same package concurrently #47482

merged 1 commit into from
Sep 4, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Sep 4, 2024

Why are these changes needed?

Currently if we run two jobs with the same working dir concurrently, upload_package_if_needed will be called concurrently and they operate on the same zip file so they will conflict with each other. The PR makes sure they each work on a different zip file.

Related issue number

Closes #47471

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao
Fix runtime env race condition when uploading the same package concur…
2a89bdd 
…rently

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Sep 4, 2024
alanwguo
alanwguo approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@alanwguo alanwguo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. Hopefully this is the only race condition for runtime envs

@jjyao jjyao merged commit 9781c6c into ray-project:master Sep 4, 2024
4 checks passed
@jjyao jjyao deleted the jjyao/rundup branch September 4, 2024 22:28
@prd-tuong-nguyen
Copy link

Thank you @jjyao
Which version will have this commit?

ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Fix runtime env race condition when uploading the same package…
31b688f 
… concurrently (ray-project#47482)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Fix runtime env race condition when uploading the same package…
9605c11 
… concurrently (ray-project#47482)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Fix runtime env race condition when uploading the same package…
0d6463e 
… concurrently (ray-project#47482)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Fix runtime env race condition when uploading the same package…
e1a6ba5 
… concurrently (ray-project#47482)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Fix runtime env race condition when uploading the same package…
8f1d90a 
… concurrently (ray-project#47482)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Fix runtime env race condition when uploading the same package…
b069cfd 
… concurrently (ray-project#47482)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Oct 15, 2024
@jjyao @ujjawal-khare
[Core] Fix runtime env race condition when uploading the same package…
b42f473 
… concurrently (ray-project#47482)

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwguo alanwguo alanwguo approved these changes

Assignees

@alanwguo alanwguo

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] Runtime envs race condition when uploading packages
3 participants
@jjyao @prd-tuong-nguyen @alanwguo