Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add torch.compile config options to old API stack. #47340

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Aug 26, 2024

Add torch.compile config options to old API stack.

Users should use the same config properties as for the new API stack's Learner:

# For the learning Policy (on the local RolloutWorker):
config.framework(
    torch_compile_learner=True,
    torch_compile_learner_dynamo_backend="aot_eager|inductor|...",
    torch_compile_learner_dynamo_mode=[None|"reduce-overhead|max-autograd|always-optimize"],
)

# For the remote RolloutWorker policies (used for inference):
config.framework(
    torch_compile_worker=True,
    torch_compile_worker_dynamo_backend="aot_eager|inductor|...",
    torch_compile_worker_dynamo_mode=[None|"reduce-overhead|max-autograd|always-optimize"],
)

This will trigger

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sven1977 sven1977 enabled auto-merge (squash) August 27, 2024 09:21
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Aug 27, 2024
@sven1977 sven1977 merged commit 78402bc into ray-project:master Aug 27, 2024
6 of 7 checks passed
@sven1977 sven1977 deleted the torch_compile_old_api_stack branch August 27, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants