-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Add Humanoid + SAC tuned_example script. #47279
Merged
sven1977
merged 4 commits into
ray-project:master
from
sven1977:add_sac_humanoid_tuned_example
Aug 22, 2024
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
"""This is WIP. | ||
|
||
On a single-GPU machine, with the --num-gpus=1 command line option, this example should | ||
learn a episode return of >1000 in ~10h, which is still very basic, but does somewhat | ||
prove SAC's capabilities. Some more hyperparameter fine tuning, longer runs, and | ||
more scale (`--num-gpus > 1` and `--num-env-runners > 0`) should help push this up. | ||
""" | ||
|
||
from torch import nn | ||
|
||
from ray.rllib.algorithms.sac.sac import SACConfig | ||
from ray.rllib.utils.test_utils import add_rllib_example_script_args | ||
|
||
parser = add_rllib_example_script_args( | ||
default_timesteps=1000000, | ||
default_reward=12000.0, | ||
default_iters=2000, | ||
) | ||
parser.set_defaults(enable_new_api_stack=True) | ||
# Use `parser` to add your own custom command line options to this script | ||
# and (if needed) use their values to set up `config` below. | ||
args = parser.parse_args() | ||
|
||
|
||
config = ( | ||
SACConfig() | ||
.api_stack( | ||
enable_rl_module_and_learner=True, | ||
enable_env_runner_and_connector_v2=True, | ||
) | ||
.environment("Humanoid-v4") | ||
.training( | ||
initial_alpha=1.001, | ||
lr=0.00005, | ||
target_entropy="auto", | ||
n_step=(1, 3), | ||
tau=0.005, | ||
train_batch_size_per_learner=256, | ||
target_network_update_freq=1, | ||
replay_buffer_config={ | ||
"type": "PrioritizedEpisodeReplayBuffer", | ||
"capacity": 1000000, | ||
"alpha": 0.6, | ||
"beta": 0.4, | ||
}, | ||
num_steps_sampled_before_learning_starts=10000, | ||
) | ||
.rl_module( | ||
model_config_dict={ | ||
"fcnet_hiddens": [1024, 1024], | ||
"fcnet_activation": "relu", | ||
"fcnet_weights_initializer": nn.init.xavier_uniform_, | ||
"post_fcnet_hiddens": [], | ||
"post_fcnet_activation": None, | ||
"post_fcnet_weights_initializer": "orthogonal_", | ||
"post_fcnet_weights_initializer_config": {"gain": 0.01}, | ||
} | ||
) | ||
.reporting( | ||
metrics_num_episodes_for_smoothing=5, | ||
min_sample_timesteps_per_iteration=1000, | ||
) | ||
) | ||
|
||
|
||
if __name__ == "__main__": | ||
from ray.rllib.utils.test_utils import run_rllib_example_script_experiment | ||
|
||
run_rllib_example_script_experiment(config, args) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how this can run with a learning rate not
None
? The new PR is merged and requireslr=None
in the new stack. Insteadactor_lr
,critic_lr
, andalpha_lr
can be used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, let me double check ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch! I must have still run it on the old master (before we merged that PR).
Fixed.