[Data] Correctly refresh elapsed time in ProgressBar output
#46974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Lee <sjl@anyscale.com>
Signed-off-by: Scott Lee <sjl@anyscale.com>
added 2 commits
August 6, 2024 10:47
Signed-off-by: Scott Lee <sjl@anyscale.com>
… into 0805-progbar-elapsed
bveeramani
approved these changes
Aug 6, 2024
| @@ -320,6 +320,9 @@ def _scheduling_loop_step(self, topology: Topology) -> bool: | |||
| # Update the progress bar to reflect scheduling decisions. | |||
| for op_state in topology.values(): | |||
| op_state.refresh_progress_bar(self._resource_manager) | |||
| # Refresh the global progress bar to update elapsed time progress. | |||
| if self._global_info and self._global_info._bar: | |||
| self._global_info._bar.refresh() | |||
There was a problem hiding this comment.
Should we add a refresh method to ProgressBar? My impression is that this is breaking an abstraction barrier by accessing the private ProgressBar._bar attribute?
There was a problem hiding this comment.
yeah good point, that will help clean up the logic as well. added it
Signed-off-by: Scott Lee <sjl@anyscale.com>
dev-goyal
pushed a commit
to dev-goyal/ray
that referenced
this pull request
Aug 8, 2024
…oject#46974) When using Ray Data with a slow UDF for map operators, the progress bar's "elapsed time" item is only updated each time a task finishes. If the task is slow, this means that the elapsed time is left "hanging" and appears to be stuck, when this is not necessarily the case. This PR fixes the refreshing of the progress bar, so that the elapsed time ticks up as expected. For the following example code, we can see the change in behavior in the ticking of the progress bar: ``` import time import ray def f(batch): time.sleep(10) return batch ds = ray.data.range(50, override_num_blocks=50).map(f) ds.materialize() ``` - Before (ticks every 10 seconds): https://github.com/user-attachments/assets/d46f0d6f-dacc-4148-a12c-001fcf44f008 - After (ticks every 1 second): https://github.com/user-attachments/assets/88807215-9e81-434f-b186-b5d597bc3c59 --------- Signed-off-by: Scott Lee <sjl@anyscale.com> Signed-off-by: Dev <dev.goyal@hinge.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When using Ray Data with a slow UDF for map operators, the progress bar's "elapsed time" item is only updated each time a task finishes. If the task is slow, this means that the elapsed time is left "hanging" and appears to be stuck, when this is not necessarily the case.
This PR fixes the refreshing of the progress bar, so that the elapsed time ticks up as expected. For the following example code, we can see the change in behavior in the ticking of the progress bar:
Before (ticks every 10 seconds):
https://github.com/user-attachments/assets/d46f0d6f-dacc-4148-a12c-001fcf44f008
After (ticks every 1 second):
https://github.com/user-attachments/assets/88807215-9e81-434f-b186-b5d597bc3c59
Related issue number
Closes #44689
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.