Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Add scale for tqdm #46816

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

Bye-legumes
Copy link
Contributor

Why are these changes needed?

When the number of row (or ref bundle currently) is large, it's difficult to read the numbers. So we need to add scale unit to show the results.

Related issue number

Checks

  • [√] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [√] I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [√] Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: zhilong <zhilong.chen@mail.mcgill.ca>
Signed-off-by: zhilong <zhilong.chen@mail.mcgill.ca>
@Bye-legumes
Copy link
Contributor Author

Bye-legumes commented Jul 26, 2024

@scottjlee HI, I found a elegant solution now. And this is what look like now. The solution is to enable unit_scale so we can call format in tqdm https://github.com/tqdm/tqdm/blob/74722959a8626fd2057be03e14dcf899c25a3fd5/tqdm/std.py#L561
image
BTW: Fixed a problem that the total need to be 0 when we use use_tqdm_ray=False. otherwise there is a exception now.

Copy link
Contributor

@scottjlee scottjlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@bveeramani bveeramani enabled auto-merge (squash) July 29, 2024 17:24
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 29, 2024
@github-actions github-actions bot disabled auto-merge July 29, 2024 20:49
@Bye-legumes
Copy link
Contributor Author

@bveeramani I just update branch to rerun the premerge, so you may need to merge it manually now? Thanks! Also take look at #46699 Thanks!

@bveeramani bveeramani merged commit b3b2306 into ray-project:master Jul 30, 2024
5 checks passed
@bveeramani
Copy link
Member

Merged! Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants