Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[py12] core tests #46650

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[py12] core tests #46650

merged 2 commits into from
Jul 18, 2024

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jul 16, 2024 •
edited
Loading

Add core unit-tests for python 3.12 version - all are passing now w00t w00t, thanks to all the great work from @hongchaodeng

Test:

  • CI

@can-anyscale can-anyscale changed the title Ray1202 [py12] core tests Jul 16, 2024
@can-anyscale can-anyscale force-pushed the ray1202 branch 6 times, most recently from 025ca87 to 24d1e55 Compare July 16, 2024 14:28
Base automatically changed from can-py312-01 to master July 16, 2024 15:15
@can-anyscale can-anyscale force-pushed the ray1202 branch 3 times, most recently from 8e0232c to 449be1a Compare July 16, 2024 20:15
@can-anyscale
[py12] core tests
10bde26 
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale added continuous-build go add ONLY when ready to merge, run all tests labels Jul 17, 2024
@can-anyscale can-anyscale force-pushed the ray1202 branch 3 times, most recently from 1a70827 to 4ed2271 Compare July 17, 2024 03:23
@can-anyscale can-anyscale marked this pull request as ready for review July 17, 2024 16:54
@can-anyscale can-anyscale requested a review from jjyao July 17, 2024 16:55
can-anyscale
can-anyscale commented Jul 17, 2024
View reviewed changes
python/ray/tests/test_tensorflow.py
import pytest
import os
import sys
# TODO(can): No tensorflow for python 3.12
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hongchaodeng skip this test for now as i haven't upgraded tensorflow yet

@can-anyscale can-anyscale force-pushed the ray1202 branch 2 times, most recently from 163d6c0 to d8779f7 Compare July 17, 2024 21:47
@can-anyscale
Copy link
Collaborator Author

address @jjyao's comments

  • use @@pytest.mark.skipif, except for the test_tensorflow file because I need to skip the whole file for python 3.12 (we haven't upgraded tensorflow for python 3.12 yet). pytest natively supports this via pytest.skip(allow_module_level=true) but that doesn't play too well with our pytest+bazel setup
  • added reasons to skip test_npu and test_intel_gpu as they are from external contributors, @hongchaodeng if there are issues we can add to the reason let me know

@can-anyscale can-anyscale requested a review from jjyao July 17, 2024 21:49
@can-anyscale can-anyscale force-pushed the ray1202 branch 8 times, most recently from 5083f1f to 4926086 Compare July 18, 2024 17:20
@can-anyscale
[py12] core tests
c2b69a4 
Signed-off-by: can <can@anyscale.com>
hongchaodeng
hongchaodeng approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@can-anyscale
Copy link
Collaborator Author

let's go!

@can-anyscale can-anyscale merged commit b490359 into master Jul 18, 2024
5 checks passed
@can-anyscale can-anyscale deleted the ray1202 branch July 18, 2024 22:06
@pcmoritz pcmoritz mentioned this pull request Jul 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongchaodeng hongchaodeng hongchaodeng approved these changes

@amogkam amogkam Awaiting requested review from amogkam

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@ericl ericl Awaiting requested review from ericl

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang

@suquark suquark Awaiting requested review from suquark

@scv119 scv119 Awaiting requested review from scv119

@c21 c21 Awaiting requested review from c21

@scottjlee scottjlee Awaiting requested review from scottjlee

@bveeramani bveeramani Awaiting requested review from bveeramani

@raulchen raulchen Awaiting requested review from raulchen

@omatthew98 omatthew98 Awaiting requested review from omatthew98

@architkulkarni architkulkarni Awaiting requested review from architkulkarni

@jjyao jjyao Awaiting requested review from jjyao

Assignees

@jjyao jjyao

@hongchaodeng hongchaodeng

Labels
continuous-build go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@can-anyscale @jjyao @hongchaodeng