Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Add PPO StatelessCarePole learning tests (+LSTM) to CI. #46324

Merged
2 changes: 1 addition & 1 deletion rllib/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ py_test(
tags = ["team:rllib", "exclusive", "learning_tests", "learning_tests_cartpole", "learning_tests_discrete", "torch_only"],
size = "large",
srcs = ["tuned_examples/appo/multi_agent_cartpole_appo.py"],
args = ["--as-test", "--enable-new-api-stack", "--num-agents=2", "--num-gpus=1"]
args = ["--as-test", "--enable-new-api-stack", "--num-agents=2", "--num-gpus=1", "--num-cpus=6"]
)
py_test(
name = "learning_tests_multi_agent_cartpole_appo_gpu",
Expand Down
7 changes: 4 additions & 3 deletions rllib/tuned_examples/appo/multi_agent_cartpole_appo.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from ray.tune.registry import register_env

parser = add_rllib_example_script_args()
parser.set_defaults(num_agents=2)
parser.set_defaults(num_agents=2, num_env_runners=5)
# Use `parser` to add your own custom command line options to this script
# and (if needed) use their values toset up `config` below.
args = parser.parse_args()
Expand All @@ -26,8 +26,9 @@
)
.environment("env", env_config={"num_agents": args.num_agents})
.training(
vf_loss_coeff=0.005,
entropy_coeff=0.0,
vf_loss_coeff=0.05,
lr=0.001,
entropy_coeff=0.1,
)
.rl_module(
model_config_dict={
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from ray.tune.registry import register_env

parser = add_rllib_example_script_args()
parser.set_defaults(num_agents=2, num_env_runners=4)
parser.set_defaults(num_agents=2, num_env_runners=5)
# Use `parser` to add your own custom command line options to this script
# and (if needed) use their values toset up `config` below.
args = parser.parse_args()
Expand Down
1 change: 0 additions & 1 deletion rllib/utils/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1474,7 +1474,6 @@ def run_rllib_example_script_experiment(
# New stack.
if config.enable_rl_module_and_learner:
# Define compute resources used.
config.resources(num_gpus=0)
config.learners(
num_learners=args.num_gpus,
num_gpus_per_learner=(
Expand Down
Loading