-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib][docs] Cherry-pick-learner-docs-263 #38137
[RLlib][docs] Cherry-pick-learner-docs-263 #38137
Conversation
Signed-off-by: Avnish <avnishnarayan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean docs change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
something weird going on with gym/mujoco. Is this expected? do we need to make a fix on the release branch? |
@avnishn Please talk to @can-anyscale . There was an issue on master when we merged Sven's Gym PR. CI would be green and release tests would be red. We applied two forward fixing PRs I believe. @can-anyscale has the most context here def |
@kouroshHakha can you merge this as is? The tests are failing because of a gym issue that this pr did not cause. |
Is the release branch also failing in the same way or it only fails in this PR? |
@rickyyx should do the pick. Are we gonna pick those changes to make this release branch green? @can-anyscale ?? |
Ok, looking at CI jobs, they are pulling from the base master which is broken, which is why all of these tests are failing. This is an CI infrastructure bug/issue. I think this is fine to merge. |
Signed-off-by: Avnish avnishnarayan@gmail.com
Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.