Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Make doc code snippet testable [10/n] #37636

Merged
merged 60 commits into from
Jul 25, 2023
Merged

[Doc] Make doc code snippet testable [10/n] #37636

merged 60 commits into from
Jul 25, 2023

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Jul 21, 2023

Why are these changes needed?

Remove # doctest: +SKIP

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

bveeramani and others added 30 commits November 21, 2022 21:00
@bveeramani
Rename "model_state_dict" to "model"
5984f1e
@bveeramani
Revert "Rename "model_state_dict" to "model""
8f58490 
This reverts commit 5984f1e.
@bveeramani
Merge remote-tracking branch 'upstream/master'
63432eb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
2c33947 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
89694a0 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fe60ca3 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
d45ae9a 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
c703dfc 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
81dd25c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fba788e 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Update annotations.py
de05655 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Revert "Update annotations.py"
fd2ff91 
This reverts commit de05655.

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
7c3ac36 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
9c7b546 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
9d7a15f 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
4f02efe 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
46f43d9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
a644307 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
e5d0bf1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fe7286c 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
51b3a09 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
79f8be9 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
53bede6 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
7cec6e3 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
9407930 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
67ae591 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
93414b8 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fcfa9a5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
fbfe52d 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
16132de 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
bveeramani and others added 17 commits June 15, 2023 11:04
@bveeramani
Merge remote-tracking branch 'upstream/master'
73dd0fb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
edd6fa6 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
07aefcf 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
ed021f1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
f0d61f1 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
40f488f 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
1742f5d 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
d5dc07a 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
b9cbe98 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
7050c96 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
6b658cf 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
a2a8887 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
193b9f4 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
e65c3d5 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'master' of https://github.com/ray-project/ray
8be7eeb 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge remote-tracking branch 'upstream/master'
415ec40 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@jjyao
[Doc] Make doc code snippet testable [10/n]
22463d8 
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao requested a review from bveeramani July 21, 2023 04:56
@bveeramani
Update traceback example
962ebca 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Merge branch 'master' into jjyao/storage
c0e4f37 
Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@jjyao
fix
dff7052 
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao merged commit 8cb07e1 into ray-project:master Jul 25, 2023
@jjyao jjyao deleted the jjyao/storage branch July 25, 2023 03:55
NripeshN pushed a commit to NripeshN/ray that referenced this pull request Aug 15, 2023
@jjyao @bveeramani @NripeshN
[Doc] Make doc code snippet testable [10/n] (ray-project#37636)
5ef1ab4 
Remove # doctest: +SKIP

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: NripeshN <nn2012@hw.ac.uk>
arvind-chandra pushed a commit to lmco/ray that referenced this pull request Aug 31, 2023
@jjyao @bveeramani @arvind-chandra
[Doc] Make doc code snippet testable [10/n] (ray-project#37636)
a9f8424 
Remove # doctest: +SKIP

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: e428265 <arvind.chandramouli@lmco.com>
vymao pushed a commit to vymao/ray that referenced this pull request Oct 11, 2023
@jjyao @bveeramani
[Doc] Make doc code snippet testable [10/n] (ray-project#37636)
2ef6c51 
Remove # doctest: +SKIP

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
Signed-off-by: Victor <vctr.y.m@example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bveeramani bveeramani bveeramani approved these changes

Assignees

@bveeramani bveeramani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjyao @bveeramani