Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick][data] Fix "ImportError: sys.meta_path is None, Python is likely ting down" from StreamingExecutor #37550

Merged
merged 1 commit into from
Jul 19, 2023
Merged

[cherry-pick][data] Fix "ImportError: sys.meta_path is None, Python is likely ting down" from StreamingExecutor #37550

merged 1 commit into from
Jul 19, 2023

Conversation

raulchen
Copy link
Contributor

Why are these changes needed?

Cherry-pick #37524 to v2.6.0. This bug will print an exception when the driver exists, but won't impact correctness.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@raulchen
[data] Fix "ImportError: sys.meta_path is None, Python is likely shut…
b4afb01 
…ting down" from StreamingExecutor (ray-project#37524)

Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen added release-blocker P0 Issue that blocks the release v2.6.0-pick labels Jul 19, 2023
zhe-thoughts
zhe-thoughts approved these changes Jul 19, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is small and clean enough. I think we can pick

@raulchen
Copy link
Contributor Author

@bveeramani Could you merge this PR?

@can-anyscale can-anyscale merged commit d2299ee into ray-project:releases/2.6.0 Jul 19, 2023
@raulchen raulchen deleted the cp-14669235f6 branch July 19, 2023 17:15
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@c21 c21 Awaiting requested review from c21 c21 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

Assignees

@zhe-thoughts zhe-thoughts

@bveeramani bveeramani

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raulchen @zhe-thoughts @bveeramani @can-anyscale