Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick][data][doc] Add DatasetConfig -> DataConfig migration guide #37383

Merged
merged 2 commits into from
Jul 13, 2023
Merged

[cherry-pick][data][doc] Add DatasetConfig -> DataConfig migration guide #37383

merged 2 commits into from
Jul 13, 2023

Conversation

raulchen
Copy link
Contributor

Cherry-pick #37278 to v2.6.0

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@raulchen
[data][doc] Add DatasetConfig -> DataConfig migration guide (ray-proj…
0688169 
…ect#37278)

- Add DatasetConfig -> DataConfig migration guide
- Move ray.train.data_config to ray.train._internal.data_config

---------

Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen added release-blocker P0 Issue that blocks the release v2.6.0-pick labels Jul 13, 2023
@bveeramani
Copy link
Member

@raulchen looks like this change breaks :book: Documentation on the release branch and on master. Could you fix before we merge this in?

/ray/doc/source/train/api/api.rst:21: WARNING: autosummary: failed to import train.data_config.DataConfig

@raulchen
fix
2872466 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen
Copy link
Contributor Author

should be fixed

@bveeramani bveeramani merged commit abd287f into ray-project:releases/2.6.0 Jul 13, 2023
@raulchen raulchen deleted the cp-e233498436 branch July 13, 2023 17:34
@akshay-anyscale akshay-anyscale mentioned this pull request Jul 21, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

@gjoliver gjoliver Awaiting requested review from gjoliver gjoliver is a code owner

@krfricke krfricke Awaiting requested review from krfricke krfricke is a code owner

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010 xwjiang2010 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@Yard1 Yard1 Awaiting requested review from Yard1 Yard1 is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

Assignees

@pcmoritz pcmoritz

@zhe-thoughts zhe-thoughts

@bveeramani bveeramani

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raulchen @bveeramani @zhe-thoughts @pcmoritz